Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pixel GPU DQM online client #45666

Merged
merged 7 commits into from
Aug 29, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 7, 2024

PR description:

This PR performs few simple updates of the pixel GPU DQM online client:

  • fix the pixel digi error collection names for the HIon menu (CMSHLT-3284)
  • add pixel heterogeneous harvesting sequence for alpaka
  • update pixelgpu_dqm_sourceclient-live to add raw data input monitoring and track harvesting
  • add 2D scatter plot for track curvature and change matching deltaR from 0.2 to 0.02
  • improvements to SoA track monitoring plugins
  • add alpakaValidation modifier to .403 harvesting steps

PR validation:

scram b runtests_TestDQMOnlineClient-pixelgpu_dqm_sourceclient runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, to be backported to CMSSW_14_0_X for 2024 data-taking purposes.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Aug 7, 2024

enable gpu

@mmusich
Copy link
Contributor Author

mmusich commented Aug 7, 2024

test parameters:

  • workflow_opts_gpu= -w upgrade
  • workflows_gpu= 12434.403, 12434.503, 12634.403

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2024

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • DQM/Integration (dqm)
  • DQM/SiPixelHeterogeneous (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@batinkov, @fioriNTU, @francescobrivio, @idebruyn, @jandrea, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Aug 7, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2024

-1

Failed Tests: UnitTests
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8efc31/40824/summary.html
COMMIT: f8de051
CMSSW: CMSSW_14_1_X_2024-08-07-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45666/40824/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3423977
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3423954
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 196 log files, 165 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 8
  • DQMHistoTests: Total histograms compared: 69308
  • DQMHistoTests: Total failures: 808
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 68500
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 7 files compared)
  • Checked 28 log files, 35 edm output root files, 8 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2024

Pull request #45666 was updated. @antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please check and sign again.

@cmsbuild
Copy link
Contributor

Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X.

@cmsbuild cmsbuild modified the milestones: CMSSW_14_1_X, CMSSW_14_2_X Aug 27, 2024
@mmusich mmusich changed the title Update Pixel GPU DQM online client [14.1.X] Update Pixel GPU DQM online client Aug 27, 2024
@cmsbuild cmsbuild modified the milestones: CMSSW_14_1_X, CMSSW_14_2_X Aug 27, 2024
@mmusich mmusich changed the title [14.1.X] Update Pixel GPU DQM online client Update Pixel GPU DQM online client Aug 27, 2024
@tjavaid
Copy link

tjavaid commented Aug 27, 2024

+1

@mmusich
Copy link
Contributor Author

mmusich commented Aug 28, 2024

@cms-sw/upgrade-l2 @cms-sw/pdmv-l2 do you have any feedback?

@AdrianoDee
Copy link
Contributor

+pdmv

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 934df06 into cms-sw:master Aug 29, 2024
28 checks passed
@mmusich mmusich deleted the mm_dev_update_pixelGPUclient branch August 31, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants